From: Victor Stinner <vstinner@python.org>
Date: Thu, 5 Oct 2023 16:31:02 +0000 (+0200)
Subject: gh-110391: socket NetworkConnectionAttributesTest always declare cli (#110401)
X-Git-Tag: v3.13.0a1~124
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e37d4557c3de0476e76ca4b8a1cc8d2566b86c79;p=thirdparty%2FPython%2Fcpython.git

gh-110391: socket NetworkConnectionAttributesTest always declare cli (#110401)

NetworkConnectionAttributesTest of test_socket now always declare the
'cli' attribute, so clientTearDown() cannot fail with AttributeError.
---

diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
index 99c4c5cbc490..09605f7e774d 100644
--- a/Lib/test/test_socket.py
+++ b/Lib/test/test_socket.py
@@ -5356,6 +5356,7 @@ class NetworkConnectionNoServer(unittest.TestCase):
 
 
 class NetworkConnectionAttributesTest(SocketTCPTest, ThreadableTest):
+    cli = None
 
     def __init__(self, methodName='runTest'):
         SocketTCPTest.__init__(self, methodName=methodName)
@@ -5365,7 +5366,8 @@ class NetworkConnectionAttributesTest(SocketTCPTest, ThreadableTest):
         self.source_port = socket_helper.find_unused_port()
 
     def clientTearDown(self):
-        self.cli.close()
+        if self.cli is not None:
+            self.cli.close()
         self.cli = None
         ThreadableTest.clientTearDown(self)