From: lpsolit%gmail.com <>
Date: Sun, 3 Jun 2007 14:21:55 +0000 (+0000)
Subject: Bug 382974: $duplicate can be set even when not marking a bug as a dupe (security... 
X-Git-Tag: bugzilla-3.1.2~189
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e39ea822a5dec23ea34c7784337247b18946a881;p=thirdparty%2Fbugzilla.git

Bug 382974: $duplicate can be set even when not marking a bug as a dupe (security check bypass) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=justdave a=LpSolit
---

diff --git a/process_bug.cgi b/process_bug.cgi
index bb0d608a5e..170fb87a53 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -951,7 +951,7 @@ $vars->{resolution} = $cgi->param('resolution') || '';
 Bugzilla::Bug->check_status_change_triggers($knob, \@idlist, $vars);
 
 # Some triggers require extra actions.
-$duplicate = $vars->{dup_id};
+$duplicate = $vars->{dup_id} if ($knob eq 'duplicate');
 $requiremilestone = $vars->{requiremilestone};
 DuplicateUserConfirm($vars->{bug_id}, $duplicate) if $vars->{DuplicateUserConfirm};
 _remove_remaining_time() if $vars->{remove_remaining_time};