From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Date: Fri, 26 Aug 2022 12:20:44 +0000 (+0200)
Subject: bitbake.conf: set BB_DEFAULT_UMASK using ??=
X-Git-Tag: lucaceresoli/bug-15201-perf-libtraceevent-missing~3117
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e3dbded499f0bd1e71abb0650ae98fd9ade94250;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

bitbake.conf: set BB_DEFAULT_UMASK using ??=

Currently, there's no way for the user's site.conf, local.conf or
similar to set BB_DEFAULT_UMASK, because those files are included by
bitbake.conf prior to the unconditional assignment of
BB_DEFAULT_UMASK. To make that possible, use a weak default assignment
instead. This is also consistent with most other variable assignments
in the lower half of bitbake.conf.

I believe the risk of a regression is very small; it would require
something like somebody having a definition of BB_DEFAULT_UMASK in a
local configuration file, and having been relying on that _not_ taking
effect.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index dd2df8a5520..52a36d788bf 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -928,7 +928,7 @@ SHELL[unexport] = "1"
 TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH').replace("_", "-")}"
 
 # Set a default umask to use for tasks for determinism
-BB_DEFAULT_UMASK = "022"
+BB_DEFAULT_UMASK ??= "022"
 
 # Complete output from bitbake
 BB_CONSOLELOG ?= "${LOG_DIR}/cooker/${MACHINE}/${DATETIME}.log"