From: Nicolas Williams <nico@cryptonector.com>
Date: Wed, 3 Oct 2012 22:22:12 +0000 (-0500)
Subject: krb5_db_delete_principal() can fail to unlock ulog
X-Git-Tag: krb5-1.11-alpha1~127
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e41971145349e1f55b6cb3336c014bd8edcb22da;p=thirdparty%2Fkrb5.git

krb5_db_delete_principal() can fail to unlock ulog

Not really: only when the KDB backend lacks a delete method.  Still.

ticket: 7403
---

diff --git a/src/lib/kdb/kdb5.c b/src/lib/kdb/kdb5.c
index 3cf116b76e..d02bb5025b 100644
--- a/src/lib/kdb/kdb5.c
+++ b/src/lib/kdb/kdb5.c
@@ -986,8 +986,10 @@ krb5_db_delete_principal(krb5_context kcontext, krb5_principal search_for)
         free(princ_name);
     }
 
-    if (v->delete_principal == NULL)
+    if (v->delete_principal == NULL) {
+        ulog_lock(kcontext, KRB5_LOCKMODE_UNLOCK);
         return KRB5_PLUGIN_OP_NOTSUPP;
+    }
 
     status = v->delete_principal(kcontext, search_for);