From: Michael Brown <mcb30@etherboot.org>
Date: Tue, 3 Jul 2007 13:44:33 +0000 (+0100)
Subject: Avoid double free on I/O buffer when rtl_transmit() returns failure.
X-Git-Tag: v0.9.3~323^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e436b993a926e7cf3eb95b918d8de3f161baeceb;p=thirdparty%2Fipxe.git

Avoid double free on I/O buffer when rtl_transmit() returns failure.

Convert printf() to DBG(); printf() is not allowed in drivers.
---

diff --git a/src/drivers/net/rtl8139.c b/src/drivers/net/rtl8139.c
index 6acffd9b8..06d40aaa3 100644
--- a/src/drivers/net/rtl8139.c
+++ b/src/drivers/net/rtl8139.c
@@ -380,8 +380,7 @@ static int rtl_transmit ( struct net_device *netdev, struct io_buffer *iobuf ) {
 
 	/* Check for space in TX ring */
 	if ( rtl->tx.iobuf[rtl->tx.next] != NULL ) {
-		printf ( "TX overflow\n" );
-		free_iob ( iobuf );
+		DBG ( "TX overflow\n" );
 		return -ENOBUFS;
 	}