From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 14 Apr 2021 05:59:22 +0000 (+0300)
Subject: drm/amd/pm: fix error code in smu_set_power_limit()
X-Git-Tag: v5.12.4~93
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e44ec34641f7af667525e550aa0cb8f3bc635f23;p=thirdparty%2Fkernel%2Fstable.git

drm/amd/pm: fix error code in smu_set_power_limit()

[ Upstream commit bbdfe5aaef3c1d5c5e62fa235ef13f064e4c1c17 ]

We should return -EINVAL instead of success if the "limit" is too high.

Fixes: e098bc9612c2 ("drm/amd/pm: optimize the power related source code layout")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index 42c4dbe3e3624..ec0037a213314 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -2086,6 +2086,7 @@ int smu_set_power_limit(struct smu_context *smu, uint32_t limit)
 		dev_err(smu->adev->dev,
 			"New power limit (%d) is over the max allowed %d\n",
 			limit, smu->max_power_limit);
+		ret = -EINVAL;
 		goto out;
 	}