From: XZ-X <xu1415@purdue.edu>
Date: Mon, 22 Jul 2024 07:12:04 +0000 (-0400)
Subject: apps/lib/apps.c: free retdb before return on OPENSSL_strdup() failure
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e4e5c0538e8e758dc3704d4788e1f0dff53aedf5;p=thirdparty%2Fopenssl.git

apps/lib/apps.c: free retdb before return on OPENSSL_strdup() failure

Fixes: c7d5ea2670c2 "Prepare to detect index changes in OCSP responder."

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
MergeDate: Mon Jun 15 14:29:23 2026
(Merged from https://github.com/openssl/openssl/pull/24981)
---

diff --git a/apps/lib/apps.c b/apps/lib/apps.c
index 40938c04101..b2756b3b1de 100644
--- a/apps/lib/apps.c
+++ b/apps/lib/apps.c
@@ -1883,8 +1883,14 @@ CA_DB *load_index(const char *dbfile, DB_ATTR *db_attr)
     }
 
     retdb->dbfname = OPENSSL_strdup(dbfile);
-    if (retdb->dbfname == NULL)
+    if (retdb->dbfname == NULL) {
+        TXT_DB_free(retdb->db);
+        retdb->db = NULL;
+        OPENSSL_free(retdb);
+        retdb = NULL;
+        ERR_raise_data(ERR_LIB_SYS, errno, "Out of memory while copying filename: %s", dbfile);
         goto err;
+    }
 
 #ifndef OPENSSL_NO_POSIX_IO
     retdb->dbst = dbst;