From: Volker Lendecke <vl@samba.org>
Date: Wed, 17 Jan 2018 13:38:41 +0000 (+0100)
Subject: pdb: Fix CID 1427624 Resource leak
X-Git-Tag: tevent-0.9.36~307
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e4f62d4e4b91395d46c99c2a5313b0536793cca7;p=thirdparty%2Fsamba.git

pdb: Fix CID 1427624 Resource leak

It's not exactly a resource leak (we only really realloc if we shrink
dramatically), but assigning the result from tdb_realloc looks nicer.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c
index 16a7a85bdfd..b06267b2d64 100644
--- a/source3/passdb/pdb_samba_dsdb.c
+++ b/source3/passdb/pdb_samba_dsdb.c
@@ -2959,7 +2959,7 @@ static NTSTATUS pdb_samba_dsdb_enum_trusteddoms(struct pdb_methods *m,
 		domains[di++] = d;
 	}
 
-	talloc_realloc(domains, domains, struct trustdom_info *, di);
+	domains = talloc_realloc(domains, domains, struct trustdom_info *, di);
 	*_domains = talloc_move(mem_ctx, &domains);
 	*_num_domains = di;
 	TALLOC_FREE(tmp_ctx);