From: Ethan Smith <ethan@ethanhs.me>
Date: Thu, 30 May 2024 14:48:18 +0000 (-0700)
Subject: gh-119336: Restore removed _PyLong_NumBits() function (#119418)
X-Git-Tag: v3.14.0a1~1700
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e50fac96e82d857ecc024b4cd4e012493b077064;p=thirdparty%2FPython%2Fcpython.git

gh-119336: Restore removed _PyLong_NumBits() function (#119418)

It is used by the pywin32 project.
---

diff --git a/Include/cpython/longobject.h b/Include/cpython/longobject.h
index 189229ee1035..96815938c827 100644
--- a/Include/cpython/longobject.h
+++ b/Include/cpython/longobject.h
@@ -60,6 +60,15 @@ PyAPI_FUNC(Py_ssize_t) PyUnstable_Long_CompactValue(const PyLongObject* op);
 // There are no error cases.
 PyAPI_FUNC(int) _PyLong_Sign(PyObject *v);
 
+/* _PyLong_NumBits.  Return the number of bits needed to represent the
+   absolute value of a long.  For example, this returns 1 for 1 and -1, 2
+   for 2 and -2, and 2 for 3 and -3.  It returns 0 for 0.
+   v must not be NULL, and must be a normalized long.
+   (size_t)-1 is returned and OverflowError set if the true result doesn't
+   fit in a size_t.
+*/
+PyAPI_FUNC(size_t) _PyLong_NumBits(PyObject *v);
+
 /* _PyLong_FromByteArray:  View the n unsigned bytes as a binary integer in
    base 256, and return a Python int with the same numeric value.
    If n is 0, the integer is 0.  Else:
diff --git a/Include/internal/pycore_long.h b/Include/internal/pycore_long.h
index f04f66d053ba..8513695c22e7 100644
--- a/Include/internal/pycore_long.h
+++ b/Include/internal/pycore_long.h
@@ -47,17 +47,6 @@ extern "C" {
 # error "_PY_LONG_DEFAULT_MAX_STR_DIGITS smaller than threshold."
 #endif
 
-// _PyLong_NumBits.  Return the number of bits needed to represent the
-// absolute value of a long.  For example, this returns 1 for 1 and -1, 2
-// for 2 and -2, and 2 for 3 and -3.  It returns 0 for 0.
-// v must not be NULL, and must be a normalized long.
-// (size_t)-1 is returned and OverflowError set if the true result doesn't
-// fit in a size_t.
-//
-// Export for 'math' shared extension.
-PyAPI_FUNC(size_t) _PyLong_NumBits(PyObject *v);
-
-
 /* runtime lifecycle */
 
 extern PyStatus _PyLong_InitTypes(PyInterpreterState *);
diff --git a/Misc/NEWS.d/next/C API/2024-05-22-17-50-48.gh-issue-119336.ff3qnS.rst b/Misc/NEWS.d/next/C API/2024-05-22-17-50-48.gh-issue-119336.ff3qnS.rst
new file mode 100644
index 000000000000..e530bb45d35e
--- /dev/null
+++ b/Misc/NEWS.d/next/C API/2024-05-22-17-50-48.gh-issue-119336.ff3qnS.rst	
@@ -0,0 +1 @@
+Restore the removed ``_PyLong_NumBits()`` function. It is used by the pywin32 project. Patch by Ethan Smith