From: Victor Stinner <vstinner@python.org>
Date: Tue, 26 Sep 2023 00:07:12 +0000 (+0200)
Subject: gh-109401: Fix threading barrier test_default_timeout() (#109875)
X-Git-Tag: v3.13.0a1~298
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e5186c3de4194de3ea8c80edb182d786f5e20944;p=thirdparty%2FPython%2Fcpython.git

gh-109401: Fix threading barrier test_default_timeout() (#109875)

Increase timeouts. Barrier default timeout should be long enough to
spawn 4 threads on a slow CI.
---

diff --git a/Lib/test/lock_tests.py b/Lib/test/lock_tests.py
index a4f52cb20ad3..0890ec87afd1 100644
--- a/Lib/test/lock_tests.py
+++ b/Lib/test/lock_tests.py
@@ -1014,13 +1014,15 @@ class BarrierTests(BaseTestCase):
         """
         Test the barrier's default timeout
         """
-        # create a barrier with a low default timeout
-        barrier = self.barriertype(self.N, timeout=0.3)
+        # gh-109401: Barrier timeout should be long enough
+        # to create 4 threads on a slow CI.
+        timeout = 1.0
+        barrier = self.barriertype(self.N, timeout=timeout)
         def f():
             i = barrier.wait()
             if i == self.N // 2:
-                # One thread is later than the default timeout of 0.3s.
-                time.sleep(1.0)
+                # One thread is later than the default timeout.
+                time.sleep(timeout * 2)
             self.assertRaises(threading.BrokenBarrierError, barrier.wait)
         self.run_threads(f)