From: Qianfeng Rong Date: Fri, 29 Aug 2025 14:02:19 +0000 (+0800) Subject: iommu/omap: Use int type to store negative error codes X-Git-Tag: v6.18-rc1~105^2^3 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e520b2520c81c5e4fe1b8ef09cb75c132debe9ac;p=thirdparty%2Flinux.git iommu/omap: Use int type to store negative error codes Change the 'ret' variable from u32 to int to store negative error codes or zero; Storing the negative error codes in unsigned type, doesn't cause an issue at runtime but it's ugly. Additionally, assigning negative error codes to unsigned type may trigger a GCC warning when the -Wsign-conversion flag is enabled. No effect on runtime. Signed-off-by: Qianfeng Rong Reviewed-by: Jason Gunthorpe Link: https://lore.kernel.org/r/20250829140219.121783-1-rongqianfeng@vivo.com Signed-off-by: Joerg Roedel --- diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index 6fb93927bdb98..5c6f5943f44b1 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -1303,8 +1303,8 @@ static int omap_iommu_map(struct iommu_domain *domain, unsigned long da, struct omap_iommu_device *iommu; struct omap_iommu *oiommu; struct iotlb_entry e; + int ret = -EINVAL; int omap_pgsz; - u32 ret = -EINVAL; int i; omap_pgsz = bytes_to_iopgsz(bytes);