From: Alex Rousskov Date: Tue, 1 Feb 2011 20:35:42 +0000 (-0700) Subject: Call ioCompletedNotification after we are done with the opening sequence, X-Git-Tag: take02~24 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e528e570c63767f1fdb9232397046346bfcc2fcf;p=thirdparty%2Fsquid.git Call ioCompletedNotification after we are done with the opening sequence, not in the middle of it. The effect should be the same, but the logs may be easier to read, and there will be fewer chances of getting into a reentrant mess of some kind. --- diff --git a/src/DiskIO/IpcIo/IpcIoFile.cc b/src/DiskIO/IpcIo/IpcIoFile.cc index 2564a7bd47..300b746d35 100644 --- a/src/DiskIO/IpcIo/IpcIoFile.cc +++ b/src/DiskIO/IpcIo/IpcIoFile.cc @@ -47,14 +47,13 @@ IpcIoFile::open(int flags, mode_t mode, RefCount callback) if (error_) return; - ioRequestor->ioCompletedNotification(); - Ipc::HereIamMessage ann(Ipc::StrandCoord(KidIdentifier, getpid())); ann.strand.tag = dbName; Ipc::TypedMsgHdr message; ann.pack(message); SendMessage(Ipc::coordinatorAddr, message); + ioRequestor->ioCompletedNotification(); return; }