From: Mark Andrews <marka@isc.org>
Date: Tue, 16 Jan 2024 03:25:27 +0000 (+1100)
Subject: Clear qctx->zversion
X-Git-Tag: v9.20.0~6^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e52c2a654bd8ad9fe06f75ee715faea33d8adc23;p=thirdparty%2Fbind9.git

Clear qctx->zversion

Clear qctx->zversion when clearing qctx->zrdataset et al in
lib/ns/query.c:qctx_freedata.  The uncleared pointer could lead to
an assertion failure if zone data needed to be re-saved which could
happen with stale data support enabled.
---

diff --git a/lib/ns/query.c b/lib/ns/query.c
index 2827fc0e0b2..203ab46257e 100644
--- a/lib/ns/query.c
+++ b/lib/ns/query.c
@@ -5411,6 +5411,7 @@ qctx_freedata(query_ctx_t *qctx) {
 		ns_client_releasename(qctx->client, &qctx->zfname);
 		dns_db_detachnode(qctx->zdb, &qctx->znode);
 		dns_db_detach(&qctx->zdb);
+		qctx->zversion = NULL;
 	}
 
 	if (qctx->fresp != NULL && !qctx->client->nodetach) {