From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 22 Apr 2021 00:57:24 +0000 (+1200)
Subject: samba-tool:testparm: Fix error with --section-name
X-Git-Tag: tevent-0.11.0~872
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e54563861b2b06370fe3a2a10d7e7df2e3e18f24;p=thirdparty%2Fsamba.git

samba-tool:testparm: Fix error with --section-name

Pass the correct parameters into LoadparmService.dump() so that
--section-name works properly.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14143

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Rowland Penny <rpenny@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/netcmd/testparm.py b/python/samba/netcmd/testparm.py
index aef24bf5c8d..5219b8c6ad9 100644
--- a/python/samba/netcmd/testparm.py
+++ b/python/samba/netcmd/testparm.py
@@ -103,7 +103,7 @@ class cmd_testparm(Command):
         else:
             if section_name is not None or parameter_name is not None:
                 if parameter_name is None:
-                    lp[section_name].dump(verbose)
+                    lp[section_name].dump(lp.default_service, verbose)
                 else:
                     lp.dump_a_parameter(parameter_name, section_name)
             else:
diff --git a/selftest/knownfail.d/bug-14143 b/selftest/knownfail.d/bug-14143
deleted file mode 100644
index f4f9bc07ffe..00000000000
--- a/selftest/knownfail.d/bug-14143
+++ /dev/null
@@ -1 +0,0 @@
-^samba.tests.netcmd.samba.tests.netcmd.TestParmTests.test_section