From: Andrew Bartlett Date: Fri, 21 May 2021 20:46:26 +0000 (+1200) Subject: spoolss: Avoid indirection via ndr_get_array_size() X-Git-Tag: tevent-0.11.0~694 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e583140e81bce9853ccb86370a2143c8b27b4984;p=thirdparty%2Fsamba.git spoolss: Avoid indirection via ndr_get_array_size() This is set in the call just above and otherwise we will (in the next commit) need an intermediate variable once we need to check error codes from ndr_get_array_size(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14710 Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall --- diff --git a/librpc/ndr/ndr_spoolss_buf.c b/librpc/ndr/ndr_spoolss_buf.c index 393d7addeb5..9b98dd36143 100644 --- a/librpc/ndr/ndr_spoolss_buf.c +++ b/librpc/ndr/ndr_spoolss_buf.c @@ -1084,7 +1084,7 @@ _PUBLIC_ enum ndr_err_code ndr_pull_spoolss_DriverInfo101(struct ndr_pull *ndr, #else NDR_CHECK(ndr_token_store(ndr, &ndr->array_size_list, &r->file_info, r->file_count)); #endif - NDR_PULL_ALLOC_N(ndr, r->file_info, ndr_get_array_size(ndr, &r->file_info)); + NDR_PULL_ALLOC_N(ndr, r->file_info, r->file_count); _mem_save_file_info_1 = NDR_PULL_GET_MEM_CTX(ndr); NDR_PULL_SET_MEM_CTX(ndr, r->file_info, 0); for (cntr_file_info_1 = 0; cntr_file_info_1 < r->file_count; cntr_file_info_1++) {