From: Jeremy Allison Date: Thu, 5 Nov 2020 23:48:08 +0000 (-0800) Subject: s3: spoolss: Make parameters in call to user_ok_token() match all other uses. X-Git-Tag: talloc-2.3.2~27 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e5e1759057a767f517bf480a2172a36623df2799;p=thirdparty%2Fsamba.git s3: spoolss: Make parameters in call to user_ok_token() match all other uses. We already have p->session_info->unix_info->unix_name, we don't need to go through a legacy call to uidtoname(p->session_info->unix_token->uid). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14568 Signed-off-by: Jeremy Allison Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Mon Nov 9 04:10:45 UTC 2020 on sn-devel-184 --- diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index f814ad96bf4..840e0280a73 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -1880,7 +1880,8 @@ WERROR _spoolss_OpenPrinterEx(struct pipes_struct *p, return WERR_ACCESS_DENIED; } - if (!user_ok_token(uidtoname(p->session_info->unix_token->uid), NULL, + if (!user_ok_token(p->session_info->unix_info->unix_name, + p->session_info->info->domain_name, p->session_info->security_token, snum) || !W_ERROR_IS_OK(print_access_check(p->session_info, p->msg_ctx,