From: Douglas Bagnall Date: Thu, 27 Jun 2019 04:57:21 +0000 (+1200) Subject: s4/scripting/get-descriptors: print usage with insufficient arguments X-Git-Tag: samba-4.11.0rc1~88 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e5e4c113713ffbc88836db6cea0245a32151748f;p=thirdparty%2Fsamba.git s4/scripting/get-descriptors: print usage with insufficient arguments Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- diff --git a/selftest/knownfail.d/usage b/selftest/knownfail.d/usage index 6aba087dd22..193e1bbb7c5 100644 --- a/selftest/knownfail.d/usage +++ b/selftest/knownfail.d/usage @@ -1,7 +1,6 @@ samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_chgtdcpass.none. samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_demodirsync_py.none. samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_findprovisionusnranges.none. -samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_get_descriptors.none. samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_mymachinepw.none. samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_rebuildextendeddn.none. samba.tests.usage.samba.tests.usage.PythonScriptUsageTests.test_renamedc.none. diff --git a/source4/scripting/bin/get-descriptors b/source4/scripting/bin/get-descriptors index 31106d434b0..bed01e7ceb3 100755 --- a/source4/scripting/bin/get-descriptors +++ b/source4/scripting/bin/get-descriptors @@ -61,6 +61,10 @@ creds = credopts.get_credentials(lp) opts = parser.parse_args()[0] +if not opts.host or not opts.localdomain or not opts.remote_domain: + parser.print_usage() + sys.exit(1) + class DescrGetter: def __init__(self, localdomain, remotedomain):