From: Alejandro Colomar <alx@kernel.org>
Date: Wed, 15 Oct 2025 16:01:14 +0000 (+0200)
Subject: src/usermod.c: Remove 'no changes' informative output
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e5f37f3e4bc250430e22c8aeeea11f024c086b86;p=thirdparty%2Fshadow.git

src/usermod.c: Remove 'no changes' informative output

No news is good news.

Debian needs to parse this message to ignore it, or alternatively check
if the call will be a no-op (which we already do) and skip the call.
If we remove this output, we're allowing Debian to remove that
complexity in their wrapper.

We don't expect this output to be very useful for interactive use
either.

Also, this message was changed from stderr to stdout recently, so we
don't need to worry about old scripts that might break due to this
change.  If there were scripts relying on that, they would have been
broken already in the previous change.

Closes: <https://github.com/shadow-maint/shadow/issues/1361>
Reported-by: Marc Haber <githubvisible@zugschlus.de>
Cc: <https://github.com/cachius>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/src/usermod.c b/src/usermod.c
index 17288d07b..a3b89a5cb 100644
--- a/src/usermod.c
+++ b/src/usermod.c
@@ -1418,7 +1418,6 @@ process_flags(int argc, char **argv)
 	      || Zflg
 #endif				/* WITH_SELINUX */
 	)) {
-		printf(_("%s: no changes\n"), Prog);
 		exit (E_SUCCESS);
 	}