From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 9 Sep 2020 15:21:28 +0000 (+0200)
Subject: dnsdist: Fix the accounting of 'active' connections
X-Git-Tag: auth-4.5.0-alpha0~14^2~20
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e5f917ccbc2d7f8284ce70c3842a3576c6512d12;p=thirdparty%2Fpdns.git

dnsdist: Fix the accounting of 'active' connections
---

diff --git a/pdns/dnsdistdist/dnsdist-tcp-downstream.cc b/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
index 03a4c41b24..0a5a11b1df 100644
--- a/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
+++ b/pdns/dnsdistdist/dnsdist-tcp-downstream.cc
@@ -440,9 +440,9 @@ IOState TCPConnectionToBackend::handleResponse(std::shared_ptr<TCPConnectionToBa
       return IOState::Done;
     }
     auto ids = std::move(it->second.d_idstate);
+    d_pendingResponses.erase(it);
     DEBUGLOG("passing response to client connection for "<<ids.qname);
     clientConn->handleResponse(clientConn, now, TCPResponse(std::move(d_responseBuffer), std::move(ids), conn));
-    d_pendingResponses.erase(it);
 
     if (!d_pendingQueries.empty()) {
       DEBUGLOG("still have some queries to send");