From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Tue, 5 Dec 2023 02:47:23 +0000 (+1300)
Subject: auth:gensec: Zero digest array in error case
X-Git-Tag: talloc-2.4.2~422
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e607a59c8065ac4676a409e6a664ac7f5bad94c3;p=thirdparty%2Fsamba.git

auth:gensec: Zero digest array in error case

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/auth/gensec/schannel.c b/auth/gensec/schannel.c
index 1f8680743e9..86527fe4685 100644
--- a/auth/gensec/schannel.c
+++ b/auth/gensec/schannel.c
@@ -208,12 +208,11 @@ static NTSTATUS netsec_do_seq_num(struct schannel_state *state,
 				      checksum,
 				      checksum_length,
 				      _sequence_key);
+		ZERO_ARRAY(digest1);
 		if (rc < 0) {
 			return gnutls_error_to_ntstatus(rc, NT_STATUS_HMAC_NOT_SUPPORTED);
 		}
 
-		ZERO_ARRAY(digest1);
-
 		rc = gnutls_cipher_init(&cipher_hnd,
 					GNUTLS_CIPHER_ARCFOUR_128,
 					&sequence_key,