From: Guido van Rossum <guido@python.org>
Date: Wed, 14 May 1997 18:43:29 +0000 (+0000)
Subject: Fix reversed test for failure in PySequence_List() and PySequence_Tuple().
X-Git-Tag: v1.5a2~15
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e61093c2187472c5761e7c282aa579c37967018e;p=thirdparty%2FPython%2Fcpython.git

Fix reversed test for failure in PySequence_List() and PySequence_Tuple().
This broke cPickle.
---

diff --git a/Objects/abstract.c b/Objects/abstract.c
index eebeacd36452..b6d4dda6d4c5 100644
--- a/Objects/abstract.c
+++ b/Objects/abstract.c
@@ -806,7 +806,7 @@ PySequence_Tuple(s)
 
   for(i=0; i < l; i++)
     {
-      if(((item=PySequence_GetItem(s,i))) ||
+      if(!(item=PySequence_GetItem(s,i)) ||
 	 PyTuple_SetItem(t,i,item) == -1)
 	{
 	  Py_DECREF(t);
@@ -830,7 +830,7 @@ PySequence_List(s)
 
   for(i=0; i < l; i++)
     {
-      if((item=PySequence_GetItem(s,i)) ||
+      if(!(item=PySequence_GetItem(s,i)) ||
 	 PyList_SetItem(t,i,item) == -1)
 	{
 	  Py_DECREF(t);