From: Nikita Sobolev <mail@sobolevn.me>
Date: Sat, 8 Jan 2022 03:51:51 +0000 (+0300)
Subject: bpo-46299: improve `test_descr.py` with stricter error handling (GH-30471)
X-Git-Tag: v3.11.0a4~50
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e63066cfed27511c9b786d61761f87f7a532571a;p=thirdparty%2FPython%2Fcpython.git

bpo-46299: improve `test_descr.py` with stricter error handling (GH-30471)
---

diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py
index a4131bec602e..e8ecacb5c4d7 100644
--- a/Lib/test/test_descr.py
+++ b/Lib/test/test_descr.py
@@ -2545,10 +2545,8 @@ order (MRO) for bases """
         m2instance.b = 2
         m2instance.a = 1
         self.assertEqual(m2instance.__dict__, "Not a dict!")
-        try:
+        with self.assertRaises(TypeError):
             dir(m2instance)
-        except TypeError:
-            pass
 
         # Two essentially featureless objects, (Ellipsis just inherits stuff
         # from object.
@@ -4066,7 +4064,7 @@ order (MRO) for bases """
         except TypeError:
             pass
         else:
-            assert 0, "best_base calculation found wanting"
+            self.fail("best_base calculation found wanting")
 
     def test_unsubclassable_types(self):
         with self.assertRaises(TypeError):
@@ -4452,6 +4450,8 @@ order (MRO) for bases """
             print("Oops!")
         except RuntimeError:
             pass
+        else:
+            self.fail("Didn't raise RuntimeError")
         finally:
             sys.stdout = test_stdout