From: Emma Smith <emma@emmatyping.dev>
Date: Wed, 28 May 2025 23:15:39 +0000 (-0700)
Subject: gh-134262: Fix off by one errors in download retry functions (GH-134867)
X-Git-Tag: v3.15.0a1~1464
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e64395e8eb8d3a9e35e3e534e87d427ff27ab0a5;p=thirdparty%2FPython%2Fcpython.git

gh-134262: Fix off by one errors in download retry functions (GH-134867)
---

diff --git a/PCbuild/get_external.py b/PCbuild/get_external.py
index 99aff63882f5..8c1155c74a64 100755
--- a/PCbuild/get_external.py
+++ b/PCbuild/get_external.py
@@ -12,7 +12,7 @@ from urllib.request import urlretrieve
 def retrieve_with_retries(download_location, output_path, reporthook,
                           max_retries=7):
     """Download a file with exponential backoff retry and save to disk."""
-    for attempt in range(max_retries):
+    for attempt in range(max_retries + 1):
         try:
             resp = urlretrieve(
                 download_location,
diff --git a/Tools/build/generate_sbom.py b/Tools/build/generate_sbom.py
index ecb7b54f6d8a..df52f8de762a 100644
--- a/Tools/build/generate_sbom.py
+++ b/Tools/build/generate_sbom.py
@@ -169,7 +169,7 @@ def download_with_retries(download_location: str,
                           base_delay: float = 2.25,
                           max_jitter: float = 1.0) -> typing.Any:
     """Download a file with exponential backoff retry."""
-    for attempt in range(max_retries):
+    for attempt in range(max_retries + 1):
         try:
             resp = urllib.request.urlopen(download_location)
         except urllib.error.URLError as ex: