From: Ronnie Sahlberg Date: Tue, 24 Jul 2007 22:03:58 +0000 (+1000) Subject: no need to have a separate assignment of the tcparray pointer followed X-Git-Tag: tevent-0.9.20~348^2~2445^2~10 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e666808f608f61f9b9bfbf026c4a1446186164cc;p=thirdparty%2Fsamba.git no need to have a separate assignment of the tcparray pointer followed by a talloc_steal() use the returned pointer in talloc_steal as the value to assign (This used to be ctdb commit 5c6375ad3bbecfa725ec3b1477f259e5a8191866) --- diff --git a/ctdb/server/ctdb_takeover.c b/ctdb/server/ctdb_takeover.c index dcc16238f67..3ddd082c7e2 100644 --- a/ctdb/server/ctdb_takeover.c +++ b/ctdb/server/ctdb_takeover.c @@ -154,8 +154,7 @@ static void takeover_ip_callback(struct ctdb_context *ctdb, int status, if (tcparray) { /* add all of the known tcp connections for this IP to the list of tcp connections to send tickle acks for */ - arp->tcparray = tcparray; - talloc_steal(arp, tcparray); + arp->tcparray = talloc_steal(arp, tcparray); state->node->tcp_array = NULL; state->node->tcp_update_needed = true;