From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sun, 11 Dec 2016 19:37:12 +0000 (-0500)
Subject: share/log: change log_syntax from "[a:b] " to "a:b: "
X-Git-Tag: v233~333^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e697dfef649ecc077e160a077f86a06f1a1ee8ed;p=thirdparty%2Fsystemd.git

share/log: change log_syntax from "[a:b] " to "a:b: "

Those square brackets don't fit how our other messages look like; we use colons
everywhere else. The "[a:b]" format was originally added in
ed5bcfbe3c3b68e59242c03649eea03a9707d318, and remained unchanged for 7 years,
but in the meantime other conventions evolved.

The new version is also one character shorter.

[/etc/systemd/system/systemd-networkd.service.d/override.conf:2] Failed to parse sec value, ignoring: ...
  ↓
/etc/systemd/system/systemd-networkd.service.d/override.conf:2: Failed to parse sec value, ignoring: ...
---

diff --git a/src/basic/log.c b/src/basic/log.c
index 9febe391ac7..4af4d55b33b 100644
--- a/src/basic/log.c
+++ b/src/basic/log.c
@@ -1162,7 +1162,7 @@ int log_syntax_internal(
                         LOG_MESSAGE_ID(SD_MESSAGE_INVALID_CONFIGURATION),
                         "CONFIG_FILE=%s", config_file,
                         "CONFIG_LINE=%u", config_line,
-                        LOG_MESSAGE("[%s:%u] %s", config_file, config_line, buffer),
+                        LOG_MESSAGE("%s:%u: %s", config_file, config_line, buffer),
                         unit_fmt, unit,
                         NULL);
 }