From: Peter Krempa Date: Thu, 9 Jan 2025 14:18:58 +0000 (+0100) Subject: virstoragetest: Add case for qcow2 image with empty string as 'data_file' X-Git-Tag: v11.1.0-rc1~203 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e6a4245d2a4db3857cfb38d4d3c4e3e0bcff6587;p=thirdparty%2Flibvirt.git virstoragetest: Add case for qcow2 image with empty string as 'data_file' Add an example image formatted by: qemu-img create -f qcow2 -o data_file=nbd+unix:///datafile?socket=/tmp/nbd,data_file_raw=true /tmp/nbddatastore.qcow2 10M -u serving as an example when qemu records an empty string as the 'data_file' field. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index 4ec837eefb..78dc644637 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -494,6 +494,11 @@ mymain(void) abs_srcdir "/virstoragetestdata/images/qcow2datafile-datafile.qcow2", VIR_STORAGE_FILE_QCOW2, EXP_PASS); + /* broken qcow2 with a 'data_file' which is an empty string */ + TEST_CHAIN("qcow2-datafile-broken", + abs_srcdir "/virstoragetestdata/images/datafile-emptystr.qcow2", + VIR_STORAGE_FILE_QCOW2, EXP_FAIL); + /* Test various combinations of qcow2 images with missing 'backing_format' */ TEST_CHAIN("qcow2-qcow2_qcow2-qcow2_qcow2-auto", abs_srcdir "/virstoragetestdata/images/qcow2_qcow2-qcow2_qcow2-auto.qcow2", diff --git a/tests/virstoragetestdata/images/datafile-emptystr.qcow2 b/tests/virstoragetestdata/images/datafile-emptystr.qcow2 new file mode 100644 index 0000000000..18fae8740b Binary files /dev/null and b/tests/virstoragetestdata/images/datafile-emptystr.qcow2 differ