From: Andrew Bartlett Date: Thu, 26 Nov 2009 21:05:59 +0000 (+1100) Subject: s4:dsdb Don't segfault with ldb_transaction_prepare_commit() without begin() X-Git-Tag: samba-4.0.0alpha9~138 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e6c1608e909b9bbc1bdceeb24d57b9333c453a3d;p=thirdparty%2Fsamba.git s4:dsdb Don't segfault with ldb_transaction_prepare_commit() without begin() It is up to other modules to complain if ldb_transaction_prepare_commit() is called before ldb_transaction_begin_transaction() Andrew Bartlett --- diff --git a/source4/dsdb/samdb/ldb_modules/linked_attributes.c b/source4/dsdb/samdb/ldb_modules/linked_attributes.c index 32f9cba8fe8..bd9af5545e3 100644 --- a/source4/dsdb/samdb/ldb_modules/linked_attributes.c +++ b/source4/dsdb/samdb/ldb_modules/linked_attributes.c @@ -1212,6 +1212,10 @@ static int linked_attributes_prepare_commit(struct ldb_module *module) talloc_get_type(ldb_module_get_private(module), struct la_private); struct la_context *ac; + if (!la_private) { + /* prepare commit without begin_transaction - let someone else return the error, just don't segfault */ + return ldb_next_prepare_commit(module); + } /* walk the list backwards, to do the first entry first, as we * added the entries with DLIST_ADD() which puts them at the * start of the list */