From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 4 Oct 2020 14:46:33 +0000 (-0400)
Subject: check for end _before_ dereferencing pointers
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e6ce8e91bcbdc8719730918ea8b2955eb844e55f;p=thirdparty%2Ffreeradius-server.git

check for end _before_ dereferencing pointers
---

diff --git a/src/lib/util/dict_util.c b/src/lib/util/dict_util.c
index 4c089e50e46..35125594c01 100644
--- a/src/lib/util/dict_util.c
+++ b/src/lib/util/dict_util.c
@@ -2907,7 +2907,7 @@ ssize_t fr_dict_valid_name(char const *name, ssize_t len)
 	 */
 	if ((len > 5) && (memcmp(name, "Attr-", 5) == 0)) unknown = true;
 
-	do {
+	while (p < end) {
 		if ((*p == '.') && unknown) p++;
 
 		if (!fr_dict_attr_allowed_chars[(uint8_t)*p]) {
@@ -2917,7 +2917,7 @@ ssize_t fr_dict_valid_name(char const *name, ssize_t len)
 			return -(p - name);
 		}
 		p++;
-	} while (p < end);
+	}
 
 	return len;
 }