From: Marc Hoersken Date: Sat, 6 Apr 2013 22:28:15 +0000 (+0200) Subject: Revert "getpart.pm: Strip carriage returns to fix Windows support" X-Git-Tag: curl-7_30_0~23 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e73db5dcbdff6763da5f8c97fe1070b4711d5a0a;p=thirdparty%2Fcurl.git Revert "getpart.pm: Strip carriage returns to fix Windows support" This reverts commit e51b23c925a2721cf7c29b2b376d3d8903cfb067. As discussed on the mailinglist, this was not the correct approach. --- diff --git a/tests/getpart.pm b/tests/getpart.pm index 2b4abf3b10..92a2378303 100644 --- a/tests/getpart.pm +++ b/tests/getpart.pm @@ -213,10 +213,9 @@ sub compareparts { # we cannot compare arrays index per index since with the base64 chunks, # they may not be "evenly" distributed - if($^O eq "MSWin32" || $^O eq "msys") { - $first =~ s/\r\n/\n/g; - $second =~ s/\r\n/\n/g; - } + # NOTE: this no longer strips off carriage returns from the arrays. Is that + # really necessary? It ruins the testing of newlines. I believe it was once + # added to enable tests on win32. if($first ne $second) { return 1;