From: Guido van Rossum <guido@python.org>
Date: Mon, 19 Jan 1998 22:26:54 +0000 (+0000)
Subject: Fix bad new bug in ftp code -- the test for existing file using NLST
X-Git-Tag: v1.5.1~930
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e7579624ef2997783f5f5354b3fcf8b0ceccabd2;p=thirdparty%2FPython%2Fcpython.git

Fix bad new bug in ftp code -- the test for existing file using NLST
would set the transfer to text mode instead of the specified mode.
---

diff --git a/Lib/urllib.py b/Lib/urllib.py
index b9a82d169211..8ecef031cf0f 100644
--- a/Lib/urllib.py
+++ b/Lib/urllib.py
@@ -521,6 +521,8 @@ class ftpwrapper:
 			except ftplib.error_perm, reason:
 				raise IOError, ('ftp error', reason), \
 				      sys.exc_info()[2]
+			# Restore the transfer mode!
+			self.ftp.voidcmd(cmd)
 			# Try to retrieve as a file
 			try:
 				cmd = 'RETR ' + file
@@ -530,6 +532,8 @@ class ftpwrapper:
 					raise IOError, ('ftp error', reason), \
 					      sys.exc_info()[2]
 		if not conn:
+			# Set transfer mode to ASCII!
+			self.ftp.voidcmd('TYPE A')
 			# Try a directory listing
 			if file: cmd = 'LIST ' + file
 			else: cmd = 'LIST'