From: Volker Lendecke <vl@samba.org>
Date: Sun, 2 Nov 2008 21:09:51 +0000 (+0100)
Subject: Remove a direct inbuf reference in reply_negprot
X-Git-Tag: samba-4.0.0alpha6~522^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e7607b95f281af349df34c5ba0b12673e6ed6250;p=thirdparty%2Fsamba.git

Remove a direct inbuf reference in reply_negprot
---

diff --git a/source3/smbd/negprot.c b/source3/smbd/negprot.c
index fe168aad3ac..43fdc1d6086 100644
--- a/source3/smbd/negprot.c
+++ b/source3/smbd/negprot.c
@@ -507,7 +507,6 @@ static const struct {
 
 void reply_negprot(struct smb_request *req)
 {
-	size_t size = smb_len(req->inbuf) + 4;
 	int choice= -1;
 	int protocol;
 	const char *p;
@@ -527,7 +526,14 @@ void reply_negprot(struct smb_request *req)
 	}
 	done_negprot = True;
 
-	if (req->inbuf[size-1] != '\0') {
+	if (req->buflen == 0) {
+		DEBUG(0, ("negprot got no protocols\n"));
+		reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
+		END_PROFILE(SMBnegprot);
+		return;
+	}
+
+	if (req->buf[req->buflen-1] != '\0') {
 		DEBUG(0, ("negprot protocols not 0-terminated\n"));
 		reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
 		END_PROFILE(SMBnegprot);