From: Günther Deschner <gd@samba.org>
Date: Thu, 13 Nov 2008 18:42:13 +0000 (+0100)
Subject: s3-svctl-server: fix remote rpc service management (bug #5888).
X-Git-Tag: samba-4.0.0alpha6~480^2~224
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e76e77c32d8fe999604939d43589b8f441daed43;p=thirdparty%2Fsamba.git

s3-svctl-server: fix remote rpc service management (bug #5888).

Don't TALLOC_FREE a non-talloced [ref] pointer.

Guenther
---

diff --git a/source3/rpc_server/srv_svcctl_nt.c b/source3/rpc_server/srv_svcctl_nt.c
index cb6657400f5..4beab6488be 100644
--- a/source3/rpc_server/srv_svcctl_nt.c
+++ b/source3/rpc_server/srv_svcctl_nt.c
@@ -690,7 +690,7 @@ WERROR _svcctl_QueryServiceConfigW(pipes_struct *p,
 	*r->out.bytes_needed = (buffer_size > r->in.buf_size) ? buffer_size : r->in.buf_size;
 
         if (buffer_size > r->in.buf_size ) {
-		TALLOC_FREE(r->out.query);
+		ZERO_STRUCTP(r->out.query);
                 return WERR_INSUFFICIENT_BUFFER;
 	}