From: Vinay Sajip Date: Tue, 16 Oct 2012 09:32:13 +0000 (+0100) Subject: Issue #16244: Merged change from 3.2. X-Git-Tag: v3.3.1rc1~799 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e7e7af45587b1a5f2486c8326f705061c44e66c3;p=thirdparty%2FPython%2Fcpython.git Issue #16244: Merged change from 3.2. --- e7e7af45587b1a5f2486c8326f705061c44e66c3 diff --cc Lib/logging/handlers.py index 2918360dc144,8349d3a7fb90..f286cd61d449 --- a/Lib/logging/handlers.py +++ b/Lib/logging/handlers.py @@@ -168,11 -133,10 +168,10 @@@ class RotatingFileHandler(BaseRotatingH if os.path.exists(dfn): os.remove(dfn) os.rename(sfn, dfn) - dfn = self.baseFilename + ".1" + dfn = self.rotation_filename(self.baseFilename + ".1") if os.path.exists(dfn): os.remove(dfn) - os.rename(self.baseFilename, dfn) + self.rotate(self.baseFilename, dfn) - self.mode = 'w' self.stream = self._open() def shouldRollover(self, record):