From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sat, 28 Mar 2020 12:03:06 +0000 (+0100)
Subject: nss-systemd: add missing jump to unlock mutex
X-Git-Tag: v246-rc1~681^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e7e9a9d0dce3fe1a133a42f69a2547749b5bcd46;p=thirdparty%2Fsystemd.git

nss-systemd: add missing jump to unlock mutex

CID#1412415.
---

diff --git a/src/nss-systemd/nss-systemd.c b/src/nss-systemd/nss-systemd.c
index 9c004616f59..08fe100c051 100644
--- a/src/nss-systemd/nss-systemd.c
+++ b/src/nss-systemd/nss-systemd.c
@@ -432,7 +432,7 @@ enum nss_status _nss_systemd_getgrent_r(
         if (!getgrent_data.by_membership) {
                 r = groupdb_iterator_get(getgrent_data.iterator, &gr);
                 if (r == -ESRCH) {
-                        /* So we finished iterating native groups now. let's now continue with iterating
+                        /* So we finished iterating native groups now. Let's now continue with iterating
                          * native memberships, and generate additional group entries for any groups
                          * referenced there that are defined in NSS only. This means for those groups there
                          * will be two or more entries generated during iteration, but this is apparently how
@@ -511,7 +511,8 @@ enum nss_status _nss_systemd_getgrent_r(
                         if (!members) {
                                 UNPROTECT_ERRNO;
                                 *errnop = ENOMEM;
-                                return NSS_STATUS_TRYAGAIN;
+                                ret = NSS_STATUS_TRYAGAIN;
+                                goto finish;
                         }
 
                         /* Note that we currently generate one group entry per user that is part of a