From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 19 Jul 2024 12:40:47 +0000 (+0200)
Subject: execute: add FIXME comment
X-Git-Tag: v257-rc1~870
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e8468541727db9cea18cf29c39f46013bce1bae3;p=thirdparty%2Fsystemd.git

execute: add FIXME comment

As requested by @YHNdnzj:

https://github.com/systemd/systemd/pull/33707#discussion_r1684055699
---

diff --git a/src/core/exec-invoke.c b/src/core/exec-invoke.c
index ea85c36581a..8c7e29f17a4 100644
--- a/src/core/exec-invoke.c
+++ b/src/core/exec-invoke.c
@@ -497,6 +497,9 @@ static int setup_output(
         i = fixup_input(context, socket_fd, params->flags & EXEC_APPLY_TTY_STDIN);
         o = fixup_output(context->std_output, socket_fd);
 
+        // FIXME: we probably should spend some time here to verify that if we inherit an fd from stdin
+        // (possibly indirect via inheritance from stdout) it is actually opened for write!
+
         if (fileno == STDERR_FILENO) {
                 ExecOutput e;
                 e = fixup_output(context->std_error, socket_fd);