From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Sat, 16 Nov 2019 08:25:11 +0000 (+1300)
Subject: ndrdump: avoid use after free
X-Git-Tag: talloc-2.3.1~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e856877ef88bf273cbf814ff17abad900ba7ea27;p=thirdparty%2Fsamba.git

ndrdump: avoid use after free

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Sun Nov 17 23:54:11 UTC 2019 on sn-devel-184
---

diff --git a/librpc/tools/ndrdump.c b/librpc/tools/ndrdump.c
index 2db6be3366b..e911cf4c1e4 100644
--- a/librpc/tools/ndrdump.c
+++ b/librpc/tools/ndrdump.c
@@ -228,10 +228,11 @@ static NTSTATUS ndrdump_pull_and_print_pipes(const char *function,
 				return ndr_map_error2ntstatus(ndr_err);
 			}
 			pipes->pipes[i].ndr_print(ndr_print, n, c);
-			talloc_free(c);
 			if (*count == 0) {
+				talloc_free(c);
 				break;
 			}
+			talloc_free(c);
 			idx++;
 		}
 	}