From: Viacheslav Dubeyko Date: Mon, 9 Mar 2026 21:49:48 +0000 (-0700) Subject: hfsplus: set ctime after setxattr and removexattr X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e89b5724aaf362cc84ecacaf56eb09a88e57441e;p=thirdparty%2Flinux.git hfsplus: set ctime after setxattr and removexattr The generic/728 test-case complains that: (1) Expected ctime needs to be changed after setxattr; (2) Expected ctime needs to be changed after removexattr. This patch adds calling inode_set_ctime_current() in __hfsplus_setxattr() and hfsplus_removexattr(). sudo ./check generic/728 FSTYP -- hfsplus PLATFORM -- Linux/x86_64 hfsplus-testing-0001 7.0.0-rc1+ #6 SMP PREEMPT_DYNAMIC Mon Mar 9 14:29:30 PDT 2026 MKFS_OPTIONS -- /dev/loop51 MOUNT_OPTIONS -- /dev/loop51 /mnt/scratch generic/728 35s ... 44s Ran: generic/728 Passed all 1 tests cc: John Paul Adrian Glaubitz cc: Yangtao Li cc: linux-fsdevel@vger.kernel.org Signed-off-by: Viacheslav Dubeyko Link: https://lore.kernel.org/r/20260309214947.1114618-2-slava@dubeyko.com Signed-off-by: Viacheslav Dubeyko --- diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c index 31b6cb9db7708..a824bcaac172b 100644 --- a/fs/hfsplus/xattr.c +++ b/fs/hfsplus/xattr.c @@ -410,6 +410,8 @@ int __hfsplus_setxattr(struct inode *inode, const char *name, goto end_setxattr; } + inode_set_ctime_current(inode); + end_setxattr: hfs_find_exit(&cat_fd); hfs_dbg("finished: res %d\n", err); @@ -895,6 +897,8 @@ static int hfsplus_removexattr(struct inode *inode, const char *name) goto end_removexattr; } + inode_set_ctime_current(inode); + end_removexattr: hfs_find_exit(&cat_fd);