From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Sat, 24 Jul 2021 10:29:19 +0000 (-0700)
Subject: bpo-44353: Improve tests covering typing.NewType pickling (GH-27302) (GH-27328)
X-Git-Tag: v3.10.0rc1~75
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e8c01749c02a97a2f5b01086951bb564121c5113;p=thirdparty%2FPython%2Fcpython.git

bpo-44353: Improve tests covering typing.NewType pickling (GH-27302) (GH-27328)

(cherry picked from commit a22b05da87bdfb081d6aaecfce136ae8dbb8680c)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
---

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 5e3fba3a8687..8cbbe622d5a4 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -3730,16 +3730,17 @@ class NewTypeTests(BaseTestCase):
     def test_pickle(self):
         UserAge = NewType('UserAge', float)
         for proto in range(pickle.HIGHEST_PROTOCOL + 1):
-            pickled = pickle.dumps(UserId, proto)
-            loaded = pickle.loads(pickled)
-            self.assertIs(loaded, UserId)
+            with self.subTest(proto=proto):
+                pickled = pickle.dumps(UserId, proto)
+                loaded = pickle.loads(pickled)
+                self.assertIs(loaded, UserId)
 
-            pickled = pickle.dumps(self.UserName, proto)
-            loaded = pickle.loads(pickled)
-            self.assertIs(loaded, self.UserName)
+                pickled = pickle.dumps(self.UserName, proto)
+                loaded = pickle.loads(pickled)
+                self.assertIs(loaded, self.UserName)
 
-            with self.assertRaises(pickle.PicklingError):
-                pickle.dumps(UserAge, proto)
+                with self.assertRaises(pickle.PicklingError):
+                    pickle.dumps(UserAge, proto)
 
 
 class NamedTupleTests(BaseTestCase):