From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Sun, 26 Oct 2025 02:15:35 +0000 (+0100)
Subject: auth: test-mech - The OTP mechanism no longer logs errors for client protocol violations
X-Git-Tag: 2.4.2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e8d30f10da16f52b56e74ac36cd216f29f091641;p=thirdparty%2Fdovecot%2Fcore.git

auth: test-mech - The OTP mechanism no longer logs errors for client protocol violations

Yet, we forgot to amend this test. It only failed in Valgrind.
---

diff --git a/src/auth/test-mech.c b/src/auth/test-mech.c
index b1a177103f..1d114f4b69 100644
--- a/src/auth/test-mech.c
+++ b/src/auth/test-mech.c
@@ -209,8 +209,8 @@ static void test_mechs(void)
 		{"EXTERNAL", UCHAR_LEN(""), "testuser", NULL, FALSE, TRUE, FALSE},
 		{"EXTERNAL", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
 		{"LOGIN", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
-		{"OTP", UCHAR_LEN(""), NULL, "invalid input", FALSE, FALSE, FALSE},
-		{"OTP", UCHAR_LEN(""), "testuser", "invalid input", FALSE, FALSE, FALSE},
+		{"OTP", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
+		{"OTP", UCHAR_LEN(""), "testuser", NULL, FALSE, FALSE, FALSE},
 		{"PLAIN", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
 		{"OAUTHBEARER", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
 		{"XOAUTH2", UCHAR_LEN(""), NULL, NULL, FALSE, FALSE, FALSE},
@@ -222,7 +222,7 @@ static void test_mechs(void)
 		{"APOP", UCHAR_LEN("1.1.1\0testuser\0tooshort"), NULL, NULL, FALSE, FALSE, FALSE},
 		{"APOP", UCHAR_LEN("1.1.1\0testuser\0responseoflen16-"), NULL, NULL, FALSE, FALSE, FALSE},
 		{"APOP", UCHAR_LEN("1.1.1"), NULL, NULL, FALSE, FALSE, FALSE},
-		{"OTP", UCHAR_LEN("somebody\0testuser"), "testuser", "unsupported response type", FALSE, TRUE, FALSE},
+		{"OTP", UCHAR_LEN("somebody\0testuser"), "testuser", NULL, FALSE, TRUE, FALSE},
 		{"CRAM-MD5", UCHAR_LEN("testuser\0response"), "testuser", NULL, FALSE, FALSE, FALSE},
 		{"PLAIN", UCHAR_LEN("testuser\0"), "testuser", NULL, FALSE, FALSE, FALSE},
 
@@ -265,9 +265,9 @@ static void test_mechs(void)
 		{"PLAIN", UCHAR_LEN("\0fa\0il\0ing\0withthis"), NULL, NULL, FALSE, FALSE, FALSE},
 		{"PLAIN", UCHAR_LEN("failingwiththis"), NULL, NULL, FALSE, FALSE, FALSE},
 		{"PLAIN", UCHAR_LEN("failing\0withthis"), NULL, NULL, FALSE, FALSE, FALSE},
-		{"OTP", UCHAR_LEN("someb\0ody\0testuser"), NULL, "invalid input", FALSE, FALSE, FALSE},
+		{"OTP", UCHAR_LEN("someb\0ody\0testuser"), NULL, NULL, FALSE, FALSE, FALSE},
 		/* phase 2 */
-		{"OTP", UCHAR_LEN("someb\0ody\0testuser"), "testuser", "unsupported response type", FALSE, TRUE, FALSE},
+		{"OTP", UCHAR_LEN("someb\0ody\0testuser"), "testuser", NULL, FALSE, TRUE, FALSE},
 		{"SCRAM-SHA-1", UCHAR_LEN("c=biws,r=fyko+d2lbbFgONRv9qkxdawL3rfcNHYJY1ZVvWVs7j,p=v0X8v3Bz2T0CJGbJQyF0X+HI4Ts="), NULL, NULL, FALSE, FALSE, FALSE},
 		{"SCRAM-SHA-1", UCHAR_LEN("iws0X8v3Bz2T0CJGbJQyF0X+HI4Ts=,,,,"), NULL, NULL, FALSE, FALSE, FALSE},
 		{"SCRAM-SHA-1", UCHAR_LEN("n,a=masteruser,,"), NULL, NULL, FALSE, FALSE, FALSE},