From: Neal Norwitz <nnorwitz@gmail.com>
Date: Thu, 18 Jan 2007 07:16:31 +0000 (+0000)
Subject: Add a comment for some code I don't understand.  Why would needsfree
X-Git-Tag: v2.5.1c1~161
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e962300d0c839868f2ace3fc174ab1f9e19cb4e9;p=thirdparty%2FPython%2Fcpython.git

Add a comment for some code I don't understand.  Why would needsfree
be true if we didn't malloc the code?  Seems like the code is wrong
or could use comments.

Also verify if the buildbots are working properly for the 2.5 branch.
---

diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
index 08977ebaabbf..89c5aaea55bd 100644
--- a/Modules/_ctypes/_ctypes.c
+++ b/Modules/_ctypes/_ctypes.c
@@ -2199,6 +2199,7 @@ static void CData_MallocBuffer(CDataObject *obj, StgDictObject *dict)
 	if ((size_t)dict->size <= sizeof(obj->b_value)) {
 		/* No need to call malloc, can use the default buffer */
 		obj->b_ptr = (char *)&obj->b_value;
+		/* XXX(nnorwitz): shouldn't b_needsfree be 0? */
 		obj->b_needsfree = 1;
 	} else {
 		/* In python 2.4, and ctypes 0.9.6, the malloc call took about