From: Jeremy Allison <jra@samba.org>
Date: Thu, 1 May 2008 15:39:16 +0000 (-0700)
Subject: Fix bug #5434 found by Ted Percival <ted@midg3t.net>.
X-Git-Tag: samba-4.0.0alpha6~801^2~1546
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e9accc2ad6a9ece83f66cc5d6d78a233a2a2c99c;p=thirdparty%2Fsamba.git

Fix bug #5434 found by Ted Percival <ted@midg3t.net>.
Introduced by me in the strlcpy cleanup. Ensure the
loaded password doesn't contain the '\n' at the end.
Jeremy.
(This used to be commit 41984743d9e89b6568119832c35ee4c0024e43a2)
---

diff --git a/source3/client/mount.cifs.c b/source3/client/mount.cifs.c
index 96ab4a8910e..d1b735525e9 100644
--- a/source3/client/mount.cifs.c
+++ b/source3/client/mount.cifs.c
@@ -236,6 +236,7 @@ static int open_cred_file(char * file_name)
 				for(length = 0;length<MOUNT_PASSWD_SIZE+1;length++) {
 					if ((temp_val[length] == '\n')
 					    || (temp_val[length] == '\0')) {
+						temp_val[length] = '\0';
 						break;
 					}
 				}
@@ -264,6 +265,7 @@ static int open_cred_file(char * file_name)
                                 for(length = 0;length<DOMAIN_SIZE+1;length++) {
 					if ((temp_val[length] == '\n')
 					    || (temp_val[length] == '\0')) {
+						temp_val[length] = '\0';
 						break;
 					}
                                 }