From: Ruben d'Arco <cyclops@prof-x.net>
Date: Mon, 10 Jun 2013 20:45:52 +0000 (+0200)
Subject: Resolve tinydnsbackend coverity warnings
X-Git-Tag: auth-3.3-rc2~38
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e9d4e38e0649265b9d9196c7b6113c7f85c062ee;p=thirdparty%2Fpdns.git

Resolve tinydnsbackend coverity warnings
(8fb03db75947122da4e5425c4b517a46c54046f3+7e8f95a953ae3b5bac93e9314a7a75486618d96d)
---

diff --git a/modules/tinydnsbackend/tinydnsbackend.cc b/modules/tinydnsbackend/tinydnsbackend.cc
index 36e1984f67..640f1b803b 100644
--- a/modules/tinydnsbackend/tinydnsbackend.cc
+++ b/modules/tinydnsbackend/tinydnsbackend.cc
@@ -61,17 +61,20 @@ TinyDNSBackend::TinyDNSBackend(const string &suffix)
 	d_locations = mustDo("locations");
 	d_ignorebogus = mustDo("ignore-bogus-records");
 	d_taiepoch = 4611686018427387904ULL + getArgAsNum("tai-adjust");
+	d_dnspacket = NULL;
+	d_cdbReader = NULL;
+	d_isAxfr = false;
+	d_isWildcardQuery = false;
 }
 
 void TinyDNSBackend::getUpdatedMasters(vector<DomainInfo>* retDomains) {
 	Lock l(&s_domainInfoLock); //TODO: We could actually lock less if we do it per suffix.
 	
-	TDI_t *domains;
 	if (! s_domainInfo.count(d_suffix)) {
-		domains = new TDI_t;
-		s_domainInfo[d_suffix] = *domains;
-	} 
-	domains = &s_domainInfo[d_suffix];
+		TDI_t tmp;
+		s_domainInfo.insert( make_pair(d_suffix,tmp) );
+	}
+	TDI_t *domains = &s_domainInfo[d_suffix];
 
 	vector<DomainInfo> allDomains;
 	getAllDomains(&allDomains);