From: Eric Snow <ericsnowcurrently@gmail.com>
Date: Mon, 5 Dec 2022 21:41:06 +0000 (-0700)
Subject: gh-99984: Fix Compiler Warnings (#100036)
X-Git-Tag: v3.12.0a3~9
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e9e63ad8653296c199446d6f7cdad889e492a34e;p=thirdparty%2FPython%2Fcpython.git

gh-99984: Fix Compiler Warnings (#100036)

https://github.com/python/cpython/issues/99984
---

diff --git a/Modules/_xxsubinterpretersmodule.c b/Modules/_xxsubinterpretersmodule.c
index d7d7fcaf00a8..0892fa3a9595 100644
--- a/Modules/_xxsubinterpretersmodule.c
+++ b/Modules/_xxsubinterpretersmodule.c
@@ -2583,7 +2583,7 @@ channel_create(PyObject *self, PyObject *Py_UNUSED(ignored))
 {
     int64_t cid = _channel_create(&_globals.channels);
     if (cid < 0) {
-        (void)handle_channel_error(cid, self, -1);
+        (void)handle_channel_error(-1, self, cid);
         return NULL;
     }
     module_state *state = get_module_state(self);
@@ -2985,6 +2985,11 @@ module_exec(PyObject *mod)
         return -1;
     }
 
+    module_state *state = get_module_state(mod);
+    if (state == NULL) {
+        goto error;
+    }
+
     /* Add exception types */
     if (interp_exceptions_init(mod) != 0) {
         goto error;
@@ -2994,7 +2999,6 @@ module_exec(PyObject *mod)
     }
 
     /* Add other types */
-    module_state *state = get_module_state(mod);
 
     // ChannelID
     state->ChannelIDType = add_new_type(