From: Joshua Lock <josh@linux.intel.com>
Date: Tue, 11 Oct 2011 17:16:02 +0000 (-0700)
Subject: hob: fix backtrace when dismissing open dialog
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e9f66d981ad7ac726988842490192b9b19920445;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

hob: fix backtrace when dismissing open dialog

Clearly a logic/indentation error - we should only try and load the recipe
should the file-chooser return OK.

Fixes [YOCTO #1668]

(Bitbake rev: db59297aa1861614ffaea4295b9b054baa8a12b9)

Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/bitbake/lib/bb/ui/hob.py b/bitbake/lib/bb/ui/hob.py
index 71ea88acd79..0fcaad54a7f 100644
--- a/bitbake/lib/bb/ui/hob.py
+++ b/bitbake/lib/bb/ui/hob.py
@@ -400,9 +400,9 @@ class MainWindow (gtk.Window):
         if response == gtk.RESPONSE_OK:
             rep.loadRecipe(recipe)
             self.save_path = recipe
+            self.model.load_image_rep(rep)
+            self.dirty = False
         chooser.destroy()
-        self.model.load_image_rep(rep)
-        self.dirty = False
 
     def bake_clicked_cb(self, button):
         build_image = True