From: Julian Seward <jseward@acm.org>
Date: Mon, 20 Jun 2005 18:14:27 +0000 (+0000)
Subject: Although it doesn't actually matter from a generated-code point of
X-Git-Tag: svn/VALGRIND_3_0_0~347
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ea8cd394bf0135db0e37625eba8a6309453fcf7b;p=thirdparty%2Fvalgrind.git

Although it doesn't actually matter from a generated-code point of
view, it doesn't make much sense for the args to
VG_(mk_SysRes_{x86,amd64}_linux) to be stated as unsigned; therefore
make them signed.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@3971
---

diff --git a/coregrind/m_syscall.c b/coregrind/m_syscall.c
index f130bc267a..d6348e7191 100644
--- a/coregrind/m_syscall.c
+++ b/coregrind/m_syscall.c
@@ -54,7 +54,7 @@
    syscall returns a value in -1 .. -4095 as a valid result so we can
    safely test with -4095.
 */
-SysRes VG_(mk_SysRes_x86_linux) ( UWord val ) {
+SysRes VG_(mk_SysRes_x86_linux) ( Word val ) {
    SysRes res;
    res.isError = val >= -4095 && val <= -1;
    res.val     = res.isError ? -val : val;
@@ -62,15 +62,14 @@ SysRes VG_(mk_SysRes_x86_linux) ( UWord val ) {
 }
 
 /* Similarly .. */
-SysRes VG_(mk_SysRes_amd64_linux) ( UWord val ) {
+SysRes VG_(mk_SysRes_amd64_linux) ( Word val ) {
    SysRes res;
    res.isError = val >= -4095 && val <= -1;
    res.val     = res.isError ? -val : val;
    return res;
 }
 
-/* PPC uses the CR7.SO bit to flag an error (CR0 in IBM-speke)
- */
+/* PPC uses the CR7.SO bit to flag an error (CR0 in IBM-speke) */
 SysRes VG_(mk_SysRes_ppc32_linux) ( UInt val, UInt errflag ) {
    SysRes res;
    res.isError = errflag != 0;
diff --git a/coregrind/pub_core_syscall.h b/coregrind/pub_core_syscall.h
index 120964fa88..19afa0c021 100644
--- a/coregrind/pub_core_syscall.h
+++ b/coregrind/pub_core_syscall.h
@@ -61,8 +61,8 @@ extern SysRes VG_(do_syscall) ( UWord sysno,
 #define vgPlain_do_syscall6(s,a,b,c,d,e,f) VG_(do_syscall)((s),(a),(b),\
                                                            (c),(d),(e),(f))
 
-extern SysRes VG_(mk_SysRes_x86_linux)   ( UWord val );
-extern SysRes VG_(mk_SysRes_amd64_linux) ( UWord val );
+extern SysRes VG_(mk_SysRes_x86_linux)   ( Word val );
+extern SysRes VG_(mk_SysRes_amd64_linux) ( Word val );
 extern SysRes VG_(mk_SysRes_ppc32_linux) ( UInt val, UInt errflag );
 extern SysRes VG_(mk_SysRes_Error)       ( UWord val );
 extern SysRes VG_(mk_SysRes_Success)     ( UWord val );