From: Guido van Rossum Date: Tue, 7 Jul 1998 22:19:27 +0000 (+0000) Subject: Fix some problems that a picky SGI compiler reported. Two were benign X-Git-Tag: v1.5.2a1~338 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eaa1ed6b42a188ff33362b47885b18993a2e0141;p=thirdparty%2FPython%2Fcpython.git Fix some problems that a picky SGI compiler reported. Two were benign (unreachable break after a return) but one was a real bug: ReadFrames() was getting a bogus framecount because of a missing '&'. --- diff --git a/Modules/almodule.c b/Modules/almodule.c index a73e1bebc2a7..7e399eac944e 100644 --- a/Modules/almodule.c +++ b/Modules/almodule.c @@ -289,12 +289,10 @@ python2param(int resource, ALpv *param, PyObject *value, ALparamInfo *pinfo) case AL_ENUM_ELEM: return python2elem(value, (void *) ¶m->value.i, pinfo->elementType); - break; case AL_INT64_ELEM: case AL_FIXED_ELEM: return python2elem(value, (void *) ¶m->value.ll, pinfo->elementType); - break; default: PyErr_SetString(ErrorObject, "unknown element type"); return -1; @@ -912,7 +910,7 @@ alp_ReadFrames(self, args) int ch; ALconfig c; - if (!PyArg_ParseTuple(args, "i", framecount)) + if (!PyArg_ParseTuple(args, "i", &framecount)) return NULL; if (framecount < 0) { PyErr_SetString(ErrorObject, "negative framecount");