From: Volker Lendecke <vl@samba.org>
Date: Mon, 11 Feb 2008 17:36:06 +0000 (+0100)
Subject: Add a missing return
X-Git-Tag: samba-3.3.0pre1~3526
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eadd15c9363a57c214ede3c489057646baca48f8;p=thirdparty%2Fsamba.git

Add a missing return

If I'm not completely blind, we should return here. Not doing it here seems not
to be a major flaw, as far as I can see we're only missing the error code. This
might account for some of the very unhelpful NT_STATUS_UNSUCCESSFUL error
messages people see during joins.

All with stake in Samba client, please check!
---

diff --git a/source/libsmb/cliconnect.c b/source/libsmb/cliconnect.c
index f3926b777b9..e97be98fc19 100644
--- a/source/libsmb/cliconnect.c
+++ b/source/libsmb/cliconnect.c
@@ -627,7 +627,7 @@ static ADS_STATUS cli_session_setup_kerberos(struct cli_state *cli, const char *
 	if (!cli_session_setup_blob(cli, negTokenTarg, session_key_krb5)) {
 		data_blob_free(&negTokenTarg);
 		data_blob_free(&session_key_krb5);
-		ADS_ERROR_NT(cli_nt_error(cli));
+		return ADS_ERROR_NT(cli_nt_error(cli));
 	}
 
 	cli_set_session_key(cli, session_key_krb5);