From: David Hankins <dhankins@isc.org>
Date: Wed, 3 Oct 2007 20:24:27 +0000 (+0000)
Subject: - Fixed a ./configure bug where compile tests were failing due to
X-Git-Tag: v4_0_0b1~18
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eaf7eb17a39081dcd1d1fc5eec0f1a608bed3373;p=thirdparty%2Fdhcp.git

- Fixed a ./configure bug where compile tests were failing due to
  "-Werror" (unused variable) rather than the actual test failure.  Lead
  to inconsistent and unworkable auto-configurations.  [ISC-Bugs #17177]
---

diff --git a/RELNOTES b/RELNOTES
index 41c2e2cc3..903221041 100644
--- a/RELNOTES
+++ b/RELNOTES
@@ -68,6 +68,10 @@ suggested fixes to <dhcp-users@isc.org>.
 - Fixed an error causing the server to lock up on lease expiration,
   reported independently by Jothilingam Vasu and Dennis Kou.
 
+- Fixed a ./configure bug where compile tests were failing due to
+  "-Werror" (unused variable) rather than the actual test failure.  Lead
+  to inconsistent and unworkable auto-configurations.
+
 			Changes since 4.0.0a2
 
 - Fix for startup where there are no IPv4 addresses on an interface.
diff --git a/configure.ac b/configure.ac
index 9ca0a4292..4549c00c2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,7 +16,7 @@ AC_PROG_CC
 # user did not specify any flags. Add warnings in this case.
 if test "$GCC" = "yes"; then
 	if test "$CFLAGS" != "$SAVE_CFLAGS"; then
-		CFLAGS="$CFLAGS -Wall -Werror -fno-strict-aliasing"
+		STD_CWARNINGS="$STD_CWARNINGS -Wall -Werror -fno-strict-aliasing"
 	fi
 fi
 
@@ -208,6 +208,10 @@ AC_CHECK_MEMBER(struct msghdr.msg_control,,
 #include <sys/socket.h>
 	])
 
+# Append selected warning levels to CFLAGS before substitution (but after
+# AC_TRY_COMPILE & etc).
+CFLAGS="$CFLAGS $STD_CWARNINGS"
+
 AC_OUTPUT([
   Makefile
   client/Makefile