From: Michael Trier Date: Fri, 2 Jan 2009 18:25:08 +0000 (+0000) Subject: Marked mssql test as failing since it cannot update identity columns. X-Git-Tag: rel_0_5_0~37 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eb1a7c1bdf65547e701e26679b0ed4635534728a;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git Marked mssql test as failing since it cannot update identity columns. --- diff --git a/lib/sqlalchemy/databases/mssql.py b/lib/sqlalchemy/databases/mssql.py index 963b0e5fec..60eb0dfe16 100644 --- a/lib/sqlalchemy/databases/mssql.py +++ b/lib/sqlalchemy/databases/mssql.py @@ -790,7 +790,6 @@ class MSSQLExecutionContext(default.DefaultExecutionContext): if self.compiled.isinsert: tbl = self.compiled.statement.table - seq_column = _table_sequence_column(tbl) self.HASIDENT = bool(seq_column) if self.dialect.auto_identity_insert and self.HASIDENT: diff --git a/test/orm/mapper.py b/test/orm/mapper.py index 5cab84175e..d486c3b041 100644 --- a/test/orm/mapper.py +++ b/test/orm/mapper.py @@ -1791,11 +1791,14 @@ class CompositeTypesTest(_base.MappedTest): eq_(g.version, g2.version) # test pk mutation - g2.version = Version(2, 1) - sess.flush() - g3 = sess.query(Graph).get(Version(2, 1)) - eq_(g2.version, g3.version) - + @testing.fails_on('mssql', 'Cannot update identity columns.') + def update_pk(): + g2.version = Version(2, 1) + sess.flush() + g3 = sess.query(Graph).get(Version(2, 1)) + eq_(g2.version, g3.version) + update_pk() + # test pk with one column NULL # TODO: can't seem to get NULL in for a PK value # in either mysql or postgres, autoincrement=False etc.