From: Nick Mathewson <nickm@torproject.org>
Date: Fri, 28 Jul 2017 13:52:34 +0000 (-0400)
Subject: Fix an unreachable memory leak in the unit tests
X-Git-Tag: tor-0.3.1.5-alpha~13^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=eb677c5870ad67e0aa883d700f630c7a9ee99af3;p=thirdparty%2Ftor.git

Fix an unreachable memory leak in the unit tests

This is CID 1415726.
---

diff --git a/src/test/test_hs.c b/src/test/test_hs.c
index b4817a21ea..5aae6c5b97 100644
--- a/src/test/test_hs.c
+++ b/src/test/test_hs.c
@@ -572,6 +572,7 @@ test_single_onion_poisoning(void *arg)
   char *dir2 = tor_strdup(get_fname_rnd("test_hs_dir2"));
   smartlist_t *services = smartlist_new();
   char *poison_path = NULL;
+  char *err_msg = NULL;
 
   /* No services, no service to verify, no problem! */
   mock_options->HiddenServiceSingleHopMode = 0;
@@ -607,7 +608,6 @@ test_single_onion_poisoning(void *arg)
   /* Add port to service 1 */
   service_1->ports = smartlist_new();
   service_2->ports = smartlist_new();
-  char *err_msg = NULL;
   rend_service_port_config_t *port1 = rend_service_parse_port_config("80", " ",
                                                                      &err_msg);
   tt_assert(port1);
@@ -806,6 +806,7 @@ test_single_onion_poisoning(void *arg)
   rend_service_free(service_2);
   UNMOCK(get_options);
   tor_free(mock_options->DataDirectory);
+  tor_free(err_msg);
 }
 
 static rend_service_t *